Skip to content

DO NOT MERGE #2439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DO NOT MERGE #2439

wants to merge 1 commit into from

Conversation

@iloveeclipse
Copy link
Member

@iloveeclipse iloveeclipse commented Oct 22, 2024

Check if API tools are working in platform UI.

This PR should fail validation because it adds new API with wrong since tag.

See #2430
See #1922

@iloveeclipse
Copy link
Member Author

iloveeclipse commented Oct 22, 2024

https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-1922/4/consoleFull

07:49:23.005 [INFO] --- tycho-apitools:4.0.8:verify (verify) @ org.eclipse.ui.workbench ---
07:49:23.007 [INFO] Resolve API baseline for org.eclipse.platform:org.eclipse.ui.workbench:eclipse-plugin:3.133.100-SNAPSHOT with linux/gtk/x86_64
07:50:08.081 [INFO] API Analysis finished in 45 s.
07:50:08.207 [ERROR] [API ERROR] File MANIFEST.MF at line 5: The minor version should be incremented in version 3.133.100, since new APIs have been added since version 3.133.0 (location: /home/jenkins/agent/workspace/eclipse.platform.ui_PR-2439/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF)
07:50:08.235 [WARNING] 1 API problems can't be mapped to the compiler log!

https://ci.eclipse.org/platform/job/eclipse.platform.ui/job/PR-2439/1/consoleFull

11:14:33.401 [INFO] --- tycho-apitools:4.0.8:verify (verify) @ org.eclipse.ui.workbench ---
11:14:33.403 [INFO] Resolve API baseline for org.eclipse.platform:org.eclipse.ui.workbench:eclipse-plugin:3.133.100-SNAPSHOT with linux/gtk/x86_64
11:15:13.323 [INFO] API Analysis finished in 39 s.
11:15:13.391 [ERROR] [API ERROR] File MANIFEST.MF at line 5: The minor version should be incremented in version 3.133.100, since new APIs have been added since version 3.133.0 (location: /home/jenkins/agent/workspace/eclipse.platform.ui_PR-1922/bundles/org.eclipse.ui.workbench/META-INF/MANIFEST.MF)
11:15:13.409 [WARNING] 1 API problems can't be mapped to the compiler log!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 51m 41s ⏱️ + 1m 9s
 7 711 tests ±0   7 482 ✅ ±0  228 💤 ±0  1 ❌ ±0 
24 294 runs  ±0  23 546 ✅ ±0  747 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit e53c3c3. ± Comparison against base commit 9f38380.

@iloveeclipse
DO NOT MERGE
972c6d0 
Check if API tools are working in platform UI.

This PR should fail validation because it adds new API with wrong since
tag.

See eclipse-platform#2430
See eclipse-platform#1922
@iloveeclipse
Copy link
Member Author

iloveeclipse commented Oct 22, 2024

OK, API tooling reports an error as expected and it is visible here:

image

and here

image
image

So whatever was in #2430 #1922 is not a "generic" problem of broken API tooling that seem to work, at least at the latest platform state of today.

@HannesWell , @laeubi : FYI

@iloveeclipse iloveeclipse deleted the api_check branch October 22, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@iloveeclipse